Skip to content

Add missing custom scalars prefix to Swift codegen#1215

Closed
designatednerd wants to merge 1 commit intomasterfrom
add/option
Closed

Add missing custom scalars prefix to Swift codegen#1215
designatednerd wants to merge 1 commit intomasterfrom
add/option

Conversation

@designatednerd
Copy link
Copy Markdown
Contributor

Addresses #1214.

@CraigSiemens
Copy link
Copy Markdown
Contributor

CraigSiemens commented May 19, 2020

I took a stab at making this change as well, though I took a slightly different approach of adding an enum for the CustomScalarFormat. I should have posted in the issue that I'd try to fix it. I'm not sure wether to make a PR for it now or not. You can take a look at my change if you'd like.

Edit: I've posted my PR here #1216. Feel free to close or accept, I'm fine with either solution.

@designatednerd
Copy link
Copy Markdown
Contributor Author

Closing in favor of #1216.

@designatednerd designatednerd deleted the add/option branch May 19, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants